-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(new sink): add Apache Doris sink support #23117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Created Jira card for Docs Team review. |
maycmlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions
maycmlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for docs
|
Hi @bingquanzhao, thank you for this PR. Please rebase on master and fix merge conflicts. There are 12k affected lines right now. |
- Update socket2 from 0.5.8 to 0.5.10 - Update sqlx from 0.8.3 to 0.8.6 - Keep mysql support in sqlx features for Doris sink
thomasqueirozb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Should be good to go realistically. Would only like to talk about the string uri and I'll commit the other required changes myself
|
It actually looks like integration tests are failing when I run |
Hi @thomasqueirozb ,I’ve addressed the type issue with base_url and fixed the integration test issues. |
|
@bingquanzhao Hi, I added header group_commit: async_mode to conf, and got an error from doris "label and group_commit can't be set at the same time". Can you provide a switch to disable label generation? (more efficiency and less integrity) |
I will add a check. When group_commit is set, do not set the label. |
The content you mentioned I have already pushed. You can give it a try. |
Thanks! It works perfectly! |
|
Hi @thomasqueirozb , Do I still need to do anything else? |
|
Hi @bingquanzhao, sorry for the delay as I was out for the last two weeks. I have not yet reviewed the latest changes in the PR but for right now no action is needed from your side :) |
|
Regarding the check-component-docs CI failure: |
Summary
This PR introduces a new Apache Doris sink for Vector, enabling users to send log data directly to Apache Doris databases using the Stream Load API. The implementation includes:
Apache Doris is a modern MPP analytical database that provides sub-second query response times on large datasets, making it ideal for real-time data warehouses and log analysis scenarios.
Change Type
Is this a breaking change?
How did you test this PR?
Local Testing
cargo testvector validatemake generate-component-docs./scripts/check_changelog_fragments.shTest Configuration Used
Environment Setup
Does this PR include user facing changes?
Notes
Implementation Details
format: Data format specification (json, csv, etc.)read_json_by_line: JSON line-by-line reading modestrip_outer_array: Array handling configurationcolumns: Column mapping specificationDocumentation
CI=true make check-docs)Dependencies
Code Quality
cargo fmtTesting Strategy
References